Compatibility with Restrict Markers#32
Closed
mrschick wants to merge 1 commit intoOCAP2:feature/cba_reworkfrom
Closed
Compatibility with Restrict Markers#32mrschick wants to merge 1 commit intoOCAP2:feature/cba_reworkfrom
mrschick wants to merge 1 commit intoOCAP2:feature/cba_reworkfrom
Conversation
fank
approved these changes
Jan 6, 2025
Contributor
Author
|
Where should I rebase these changes onto, now that the |
Member
|
@mrschick it is in the main branch, start from there |
Contributor
Author
|
Ah, got it, I was missing the file paths I originally modified. Found them now. |
Contributor
Author
|
But GitHub won't let me retarget the PR, despite having rebased the working branch, so I'll just create a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mod Restrict Markers handles any received global marker and turns it into a local one on any client that is close enough to the creator. Internally it handles the markers of a dedicated server so that the server receives any created marker, but does not duplicate it if it is re-shared to others.
However, the re-sharing creates new local markers on clients, which are then recorded by OCAP events and sent to the server. This causes the server to record many duplicated markers, which harms playback performance.
My fix checks whether Restrict Markers is loaded and enabled on the server, and if so blocks any OCAP marker event on clients from being forwarded to the server.